[webkit-reviews] review granted: [Bug 172956] [WebIDL] PutForwards is not implemented to spec as illustrated by the WPT WebIDL/ecmascript-binding/put-forwards.html : [Attachment 312128] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 172956: [WebIDL] PutForwards is not implemented to spec as illustrated by
the WPT WebIDL/ecmascript-binding/put-forwards.html
https://bugs.webkit.org/show_bug.cgi?id=172956

Attachment 312128: Patch

https://bugs.webkit.org/attachment.cgi?id=312128&action=review




--- Comment #13 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 312128
  --> https://bugs.webkit.org/attachment.cgi?id=312128
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312128&action=review

r=me

> Source/WebCore/ChangeLog:7
> +

Link to the spec?

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4601
> +	   # FIXME: What should the second value to the PutPropertySlot be?

We should probably file a bug against the WebIDL spec about the missing "Throw"
argument to ES's Set():
Perform ? Set(Q, forwardId, V).

I am assuming false is the right thing to do though.

> LayoutTests/imported/w3c/ChangeLog:10
> +2017-06-05  Sam Weinig  <sam at webkit.org>

Double changelog.