[webkit-reviews] review granted: [Bug 174772] REGRESSION(r216944): Fallback fonts aren't invisible when the primary font is loading : [Attachment 316559] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 27 15:41:23 PDT 2017


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 174772: REGRESSION(r216944): Fallback fonts aren't invisible when the
primary font is loading
https://bugs.webkit.org/show_bug.cgi?id=174772

Attachment 316559: Patch

https://bugs.webkit.org/attachment.cgi?id=316559&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 316559
  --> https://bugs.webkit.org/attachment.cgi?id=316559
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316559&action=review

> Source/WebCore/ChangeLog:3
> +	   REGRESSION(r216944): Fallback fonts aren't invisible when the
primary font is loading

The double negation makes this a little hard to follow. Maybe "Fallback fonts
are visible, but should not be, when the primary font is loading"


More information about the webkit-reviews mailing list