[webkit-reviews] review denied: [Bug 174907] ToyLocks: Mutex was deprecated then removed : [Attachment 316575] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 27 15:13:42 PDT 2017


Filip Pizlo <fpizlo at apple.com> has denied JF Bastien <jfbastien at apple.com>'s
request for review:
Bug 174907: ToyLocks: Mutex was deprecated then removed
https://bugs.webkit.org/show_bug.cgi?id=174907

Attachment 316575: patch

https://bugs.webkit.org/attachment.cgi?id=316575&action=review




--- Comment #2 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 316575
  --> https://bugs.webkit.org/attachment.cgi?id=316575
patch

I think the proper fix is to introduce a pthread_mutex-based lock, so that we
have one in the test.


More information about the webkit-reviews mailing list