[webkit-reviews] review denied: [Bug 174703] Web Inspector: Avoid subclassing WebInspector.Object if we do not need to : [Attachment 316063] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has denied Joseph Pecoraro <joepeck at webkit.org>'s
request for review:
Bug 174703: Web Inspector: Avoid subclassing WebInspector.Object if we do not
need to
https://bugs.webkit.org/show_bug.cgi?id=174703

Attachment 316063: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=316063&action=review




--- Comment #3 from Brian Burg <bburg at apple.com> ---
Comment on attachment 316063
  --> https://bugs.webkit.org/attachment.cgi?id=316063
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=316063&action=review

Is there any particular motivation for this? Code cleanup, correctness,
performance?

> Source/WebInspectorUI/UserInterface/Models/ApplicationCacheFrame.js:26
> +WebInspector.ApplicationCacheFrame = class ApplicationCacheFrame

I guess we don't type check anywhere that the target of saveIdentityToCookie is
a subclass of object?

> Source/WebInspectorUI/UserInterface/Models/DOMSearchMatchObject.js:27
>  {

Sidenote: this class needs to be cleaned up. It knows a lot of style classes
for being in Models/ directory.

> Source/WebInspectorUI/UserInterface/Models/Probe.js:27
> +WebInspector.ProbeSample = class ProbeSample

r-, this class dispatches events.