[webkit-reviews] review granted: [Bug 174719] [WebIDL] Make a few parameters non-nullable in inspector IDL files : [Attachment 316105] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 174719: [WebIDL] Make a few parameters non-nullable in inspector IDL files
https://bugs.webkit.org/show_bug.cgi?id=174719

Attachment 316105: Patch

https://bugs.webkit.org/attachment.cgi?id=316105&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 316105
  --> https://bugs.webkit.org/attachment.cgi?id=316105
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316105&action=review

r=me

> Source/WebCore/inspector/InspectorFrontendHost.cpp:392
>      if (!is<MouseEvent>(event))
>	   return;

If this is the case should we just change the IDL to take a MouseEvent instead
of an Event?