[webkit-reviews] review requested: [Bug 174672] WebDriver: implement page load timeout : [Attachment 315982] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has asked  for review:
Bug 174672: WebDriver: implement page load timeout
https://bugs.webkit.org/show_bug.cgi?id=174672

Attachment 315982: Patch

https://bugs.webkit.org/attachment.cgi?id=315982&action=review




--- Comment #1 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Created attachment 315982

  --> https://bugs.webkit.org/attachment.cgi?id=315982&action=review

Patch

Note that this fixes testShouldTimeoutOnPageLoadTakingTooLong but not
testClickShouldTimeout. The wait after a click is racy. Right after the click
happens in the UI process, the page load hasn't started yet, so we can't start
the wait there like we do with navigation commands, and when the command
returns and thr web driver asks the browser to wait, the load has already
happened.  I don't think it's possible to solve that, and I don't think it's
worth it either, since the test case is actually testing a very weird case
(very small timeout and very fast load).