[webkit-reviews] review granted: [Bug 141469] [GTK] Layout Test http/tests/media/hls/hls-progress.html is failing : [Attachment 315978] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Charlie Turner
<cturner at igalia.com>'s request for review:
Bug 141469: [GTK] Layout Test http/tests/media/hls/hls-progress.html is failing
https://bugs.webkit.org/show_bug.cgi?id=141469

Attachment 315978: Patch

https://bugs.webkit.org/attachment.cgi?id=315978&action=review




--- Comment #7 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 315978
  --> https://bugs.webkit.org/attachment.cgi?id=315978
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315978&action=review

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1223
> +    GstElement* result = GST_ELEMENT(g_value_get_object(&item));
> +    g_value_unset(&item);
> +
> +    return gst_element_query(result, query);

You're getting the result, then unset the item and perform the query. When you
unset the item, we lose the reference that we own because the unset is going to
unref the object. It will be alive after that unset because it is alive inside
the pipeline but it will be cleaner if we just do something like:

GstElement* resultElement = GST_ELEMENT(g_value_get_object(&item));
bool queryResult = gst_element_query(resultElement, query);
g_value_unset(&item);
return queryResult;