[webkit-reviews] review denied: [Bug 173883] [GCrypt] Key serialization support : [Attachment 314464] Patch

[bugzilla-daemon at webkit.org]

Jiewen Tan <jiewen_tan at apple.com> has denied Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 173883: [GCrypt] Key serialization support
https://bugs.webkit.org/show_bug.cgi?id=173883

Attachment 314464: Patch

https://bugs.webkit.org/attachment.cgi?id=314464&action=review




--- Comment #6 from Jiewen Tan <jiewen_tan at apple.com> ---
Comment on attachment 314464
  --> https://bugs.webkit.org/attachment.cgi?id=314464
Patch

In general, I don't believe we need to encrypt CryptoKey objects when they are
stored into the indexedDB. However, this functionality has been implemented
before I take over the WebCrypto API, and it is hard to remove for backward
compatibility. I recommend GTK+ not to follow this approach at least you have
legitimate reasons for it.