[webkit-reviews] review denied: [Bug 173697] [GCrypt] Implement CryptoKeyRSA PKCS#8 exports : [Attachment 314463] Patch

[bugzilla-daemon at webkit.org]

Jiewen Tan <jiewen_tan at apple.com> has denied Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 173697: [GCrypt] Implement CryptoKeyRSA PKCS#8 exports
https://bugs.webkit.org/show_bug.cgi?id=173697

Attachment 314463: Patch

https://bugs.webkit.org/attachment.cgi?id=314463&action=review




--- Comment #10 from Jiewen Tan <jiewen_tan at apple.com> ---
Comment on attachment 314463
  --> https://bugs.webkit.org/attachment.cgi?id=314463
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314463&action=review

Looks good to me. r- because of duplicated functions.

> Source/WebCore/crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:377
> +	   if (!PAL::TASN1::writeElement(pkcs8,
"privateKeyAlgorithm.algorithm", "1.2.840.113549.1.1.1", 1))

Constant for "1.2.840.113549.1.1.1".

> Source/WebCore/crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:381
> +	   if (!PAL::TASN1::writeElement(pkcs8,
"privateKeyAlgorithm.parameters", "\x05\x00", 2))

Ditto for "\x05\x00".

> Source/WebCore/crypto/gcrypt/GCryptUtilities.h:159
> +static inline std::optional<Vector<uint8_t>> mpiSignedData(gcry_mpi_t mpi)

Remove these two duplicated function after Bug 173695 is resolved.