[webkit-reviews] review granted: [Bug 181074] Clean up context menu code : [Attachment 330004] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 28 14:01:34 PST 2017
Brent Fulgham <bfulgham at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 181074: Clean up context menu code
https://bugs.webkit.org/show_bug.cgi?id=181074
Attachment 330004: Patch
https://bugs.webkit.org/attachment.cgi?id=330004&action=review
--- Comment #7 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 330004
--> https://bugs.webkit.org/attachment.cgi?id=330004
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=330004&action=review
Nice cleanup! r=me.
> Source/WebKit/ChangeLog:10
> + Remove dead iOS code. Reduce allocations. Add stub for WPE.
Yay!
> Source/WebKit/UIProcess/WebPageProxy.cpp:4732
> + m_activeContextMenu = m_pageClient.createContextMenuProxy(*this,
WTFMove(contextMenuContextData), userData);
Is it okay to move 'contextMenuContextData' here, after also assigning it
above? I guess the assignment is copying, so never mind.
More information about the webkit-reviews
mailing list