[webkit-reviews] review granted: [Bug 180897] Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI : [Attachment 330077] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 28 13:54:26 PST 2017


Brent Fulgham <bfulgham at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 180897: Use new WebsiteDataStore passed in through
decidePolicyForNavigation SPI
https://bugs.webkit.org/show_bug.cgi?id=180897

Attachment 330077: Patch

https://bugs.webkit.org/attachment.cgi?id=330077&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 330077
  --> https://bugs.webkit.org/attachment.cgi?id=330077
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330077&action=review

r=me

> Source/WebKit/ChangeLog:20
> +	   (WebKit::WebProcessPool::pageRemovedFromProcess): Deleted.

These were just renamed to match their purpose, right?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:885
> +    */

Did you mean to leave this commented-out code?


More information about the webkit-reviews mailing list