[webkit-reviews] review granted: [Bug 181035] Support service worker interception of request with blob body : [Attachment 329921] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 20 10:14:47 PST 2017


Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 181035: Support service worker interception of request with blob body
https://bugs.webkit.org/show_bug.cgi?id=181035

Attachment 329921: Patch

https://bugs.webkit.org/attachment.cgi?id=329921&action=review




--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 329921
  --> https://bugs.webkit.org/attachment.cgi?id=329921
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329921&action=review

> Source/WebKit/NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:74
> +void NetworkBlobRegistry::registerBlobURL(NetworkConnectionToWebProcess*
connection, const WebCore::URL& url, const WebCore::URL& srcURL, bool
bypassConnectionCheck)

Coding style says we need a prefix for such boolean variables, maybe
shouldBypassConnectionCheck ?


More information about the webkit-reviews mailing list