[webkit-reviews] review granted: [Bug 181042] Do not reuse resource for memory cache if selected service worker differs : [Attachment 329926] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 181042: Do not reuse resource for memory cache if selected service worker
differs
https://bugs.webkit.org/show_bug.cgi?id=181042

Attachment 329926: Patch

https://bugs.webkit.org/attachment.cgi?id=329926&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 329926
  --> https://bugs.webkit.org/attachment.cgi?id=329926
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329926&action=review

> Source/WebCore/loader/cache/CachedResourceLoader.cpp:1028
> +    if (cachedResourceRequest.options().serviceWorkerIdentifier !=
existingResource->options().serviceWorkerIdentifier) {

I think we should add a comment or a FIXME to state that this area is under
specified and that we should try specificying/validating this with other
browsers.
Now it feels safer to do that to limit weird bugs/flakinesses.