[webkit-reviews] review granted: [Bug 180832] [Web Animations] Use is<> when possible : [Attachment 329389] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 14 13:10:41 PST 2017

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 180832: [Web Animations] Use is<> when possible

Attachment 329389: Patch


--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 329389
  --> https://bugs.webkit.org/attachment.cgi?id=329389

View in context: https://bugs.webkit.org/attachment.cgi?id=329389&action=review

> Source/WebCore/animation/WebAnimation.cpp:748
> -	   downcast<KeyframeEffect>(*m_effect).startOrStopAccelerated();
> +    if (is<KeyframeEffect>(m_effect))
> +	   downcast<KeyframeEffect>(*m_effect).updateAcceleratedPlayState();

Did you intend to make this change?

More information about the webkit-reviews mailing list