[webkit-reviews] review granted: [Bug 180788] Make WebsitePolicies a proper class with getters and setters : [Attachment 329301] Patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 180788: Make WebsitePolicies a proper class with getters and setters
https://bugs.webkit.org/show_bug.cgi?id=180788

Attachment 329301: Patch

https://bugs.webkit.org/attachment.cgi?id=329301&action=review




--- Comment #2 from Andy Estes <aestes at apple.com> ---
Comment on attachment 329301
  --> https://bugs.webkit.org/attachment.cgi?id=329301
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329301&action=review

> Source/WebKit/Shared/WebsitePolicies.h:71
> +    const Vector<WebCore::HTTPHeaderField>& customHeaderFields() { return
m_customHeaderFields; }

Should be const-qualified.

> Source/WebKit/UIProcess/API/APIWebsitePolicies.h:50
> +    const Vector<WebCore::HTTPHeaderField> customHeaderFields() { return
m_websitePolicies.customHeaderFields(); }

Should be const-qualified.

It's also weird to return a const value.