[webkit-reviews] review granted: [Bug 176526] Add support for builderNameToIDMap in BuildbotSyncer : [Attachment 328622] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 6 22:23:21 PST 2017

Ryosuke Niwa <rniwa at webkit.org> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 176526: Add support for builderNameToIDMap in BuildbotSyncer

Attachment 328622: Updated patch


--- Comment #12 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 328622
  --> https://bugs.webkit.org/attachment.cgi?id=328622
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328622&action=review

r=me provided buildbot09BuildersURL and mockBuildbot09Builders are removed, and
tests are added for getBuilderNameToIDMap.

> Websites/perf.webkit.org/server-tests/resources/mock-data.js:21
> +    buildbot09BuildersURL() {return '/api/v2/builders'},

Again, I don't think we should add these since we're not simultaneously
supporting both 0.8 and 0.9.

> Websites/perf.webkit.org/server-tests/resources/mock-data.js:248
> +    mockBuildbot09Builders: function ()


> Websites/perf.webkit.org/tools/js/buildbot-triggerable.js:31
> +    getBuilderNameToIDMap()

Add a test for this function since it's not used.

More information about the webkit-reviews mailing list