[webkit-reviews] review granted: [Bug 180477] We should be able to recover after a Service Worker process crash : [Attachment 328675] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 180477: We should be able to recover after a Service Worker process crash
https://bugs.webkit.org/show_bug.cgi?id=180477

Attachment 328675: Patch

https://bugs.webkit.org/attachment.cgi?id=328675&action=review




--- Comment #5 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 328675
  --> https://bugs.webkit.org/attachment.cgi?id=328675
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328675&action=review

> Source/WebKit/StorageProcess/ServiceWorker/WebSWServerConnection.h:98
> +    template<typename U> static void sendToContextProcess(U&& message);

Why static?

In a future world of multiple context processes, how can this possibly be
static?

If it's a convenience because of the lambda captures... can we capture the
connection, or a way of looking the connection up?