[webkit-reviews] review requested: [Bug 180137] Build should fail early if needed Perl modules are not installed : [Attachment 327974] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has asked  for review:
Bug 180137: Build should fail early if needed Perl modules are not installed
https://bugs.webkit.org/show_bug.cgi?id=180137

Attachment 327974: Patch

https://bugs.webkit.org/attachment.cgi?id=327974&action=review




--- Comment #19 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 327974
  --> https://bugs.webkit.org/attachment.cgi?id=327974
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327974&action=review

> Source/cmake/WebKitCommon.cmake:21
> +    find_package(PerlModules COMPONENTS File::Copy::Recursive REQUIRED)

But see bug #180479

> Source/cmake/WebKitCommon.cmake:22
> +    find_package(PerlModules COMPONENTS JSON::PP REQUIRED)

This is apparently a core Perl module, so I'm not sure if we need to test for
it? Does anyone know?