[webkit-reviews] review granted: [Bug 176944] Storage Access API: Make document.hasStorageAccess a function and always allow access for same-origin iframes : [Attachment 328541] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 6 09:44:26 PST 2017


Brent Fulgham <bfulgham at webkit.org> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 176944: Storage Access API: Make document.hasStorageAccess a function and
always allow access for same-origin iframes
https://bugs.webkit.org/show_bug.cgi?id=176944

Attachment 328541: Patch

https://bugs.webkit.org/attachment.cgi?id=328541&action=review




--- Comment #9 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 328541
  --> https://bugs.webkit.org/attachment.cgi?id=328541
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328541&action=review

r=me, but please correct the minor style issues I mentioned before landing.

> Source/WebCore/dom/Document.cpp:7416
> +    auto& topSecurityOrigin = this->topDocument().securityOrigin();

You don't need 'this->topDocument()' here, just "topDocument()" should work.

> Source/WebCore/dom/Document.cpp:7423
> +    if (page) {

We prefer: "if (Page* page = this->page()) {" since page is not used outside
the conditional.


More information about the webkit-reviews mailing list