[webkit-reviews] review denied: [Bug 180359] Add support https://w3c.github.io/ServiceWorker/#on-client-unload-algorithm : [Attachment 328354] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied youenn fablet <youennf at gmail.com>'s
request for review:
Bug 180359: Add support
https://w3c.github.io/ServiceWorker/#on-client-unload-algorithm
https://bugs.webkit.org/show_bug.cgi?id=180359

Attachment 328354: Patch

https://bugs.webkit.org/attachment.cgi?id=328354&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 328354
  --> https://bugs.webkit.org/attachment.cgi?id=328354
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328354&action=review

> Source/WebCore/workers/service/server/SWServerRegistration.cpp:165
> +    handleClientUnload();

This looks wrong to me. The fact that removeClientUsingRegistration() is called
does not necessarily mean a client was unloaded.