[webkit-reviews] review granted: [Bug 180359] Add support https://w3c.github.io/ServiceWorker/#on-client-unload-algorithm : [Attachment 328354] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 180359: Add support
https://w3c.github.io/ServiceWorker/#on-client-unload-algorithm
https://bugs.webkit.org/show_bug.cgi?id=180359

Attachment 328354: Patch

https://bugs.webkit.org/attachment.cgi?id=328354&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 328354
  --> https://bugs.webkit.org/attachment.cgi?id=328354
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=328354&action=review

yeah, seems fine given the client unload algorithm.

> Source/WebCore/workers/service/server/SWServerRegistration.cpp:293
> +	   return;

Technically the spec does not return here. I don't know if is matters or if it
is a bug in the spec. Do we ever want to call tryActivate() on a registration
that is uninstalling?