[webkit-reviews] review denied: [Bug 175995] [Cache API] Support cache names persistency : [Attachment 319119] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied youenn fablet
<youennf at gmail.com>'s request for review:
Bug 175995: [Cache API] Support cache names persistency
https://bugs.webkit.org/show_bug.cgi?id=175995

Attachment 319119: Patch

https://bugs.webkit.org/attachment.cgi?id=319119&action=review




--- Comment #9 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 319119
  --> https://bugs.webkit.org/attachment.cgi?id=319119
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319119&action=review

> Source/WebCore/Modules/cache/CacheStorageConnection.h:49
> +    // Used only for testing purposes.
> +    virtual void setPersistency(const String& /* origin */, bool /*
isPersistent */, DOMCache::CompletionCallback&& callback) {
callback(DOMCache::Error::NotImplemented); }

Maybe we should call this setPersistencyForTesting, and I think we should do
something similar to setPrivateBrowsingEnabled instead and use SessionID to
determine whether a cache should touch the disk or not.