[webkit-reviews] review granted: [Bug 175619] [WebCrypto] Push WorkQueue dispatches for EC algorithms into shared code : [Attachment 319069] Patch

[bugzilla-daemon at webkit.org]

Jiewen Tan <jiewen_tan at apple.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 175619: [WebCrypto] Push WorkQueue dispatches for EC algorithms into shared
code
https://bugs.webkit.org/show_bug.cgi?id=175619

Attachment 319069: Patch

https://bugs.webkit.org/attachment.cgi?id=319069&action=review




--- Comment #6 from Jiewen Tan <jiewen_tan at apple.com> ---
Comment on attachment 319069
  --> https://bugs.webkit.org/attachment.cgi?id=319069
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319069&action=review

Looks good to me. r=me. Good job.

> Source/WebCore/crypto/algorithms/CryptoAlgorithmECDH.cpp:117
> +    context.ref();

It maybe better to add a comment here to state that this is the only special
case that we have this unifiedCallback. Therefore, we cannot utilize the
dispatchOperation infrastructure, and it is not necessary to make one for it.