[webkit-reviews] review granted: [Bug 175866] Add support for ReadableStream storage in FetchBody : [Attachment 318834] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 175866: Add support for ReadableStream storage in FetchBody
https://bugs.webkit.org/show_bug.cgi?id=175866

Attachment 318834: Patch

https://bugs.webkit.org/attachment.cgi?id=318834&action=review




--- Comment #8 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 318834
  --> https://bugs.webkit.org/attachment.cgi?id=318834
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318834&action=review

> Source/WebCore/Modules/fetch/FetchBody.cpp:67
> +    }, [&](RefPtr<ReadableStream>&) mutable {
> +	   FetchBody body;
> +	   body.m_isReadableStream = true;
> +	   return body;

Now that ReadableStream has a form, can FetchBody store it? The
'm_isReadableStream' has always been a bit confusing.

> Source/WebCore/Modules/fetch/FetchRequest.idl:34
> -// FIXME: Should include ReadableStream
>  typedef (Blob or BufferSource or DOMFormData or URLSearchParams or
USVString) BodyInit;

Should this not include ReadableStream?