[webkit-reviews] review requested: [Bug 175803] [CMake] Use find_package for SQLite : [Attachment 318921] Patch

[bugzilla-daemon at webkit.org]

Don Olmstead <don.olmstead at sony.com> has asked	for review:
Bug 175803: [CMake] Use find_package for SQLite
https://bugs.webkit.org/show_bug.cgi?id=175803

Attachment 318921: Patch

https://bugs.webkit.org/attachment.cgi?id=318921&action=review




--- Comment #12 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 318921
  --> https://bugs.webkit.org/attachment.cgi?id=318921
Patch

Changed this so its now for all ports.

The whole SQLite3${DEBUG_SUFFIX} seems to throw a wrench in using find_package
for AppleWin so set(SQLITE_LIBRARIES) was used instead. ${SQLITE_INCLUDE_DIR}
doesn't need to be set since its ignored when its just empty. If find_package
were used without REQUIRED then it would be set to NOTFOUND which would error.

I think this is probably what we want to do with the other WebCore libraries
that are common between all ports, zlib, xml2, xslt.