[webkit-reviews] review granted: [Bug 174614] WebDriver: implement user prompt commands : [Attachment 317406] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 174614: WebDriver: implement user prompt commands
https://bugs.webkit.org/show_bug.cgi?id=174614

Attachment 317406: Patch

https://bugs.webkit.org/attachment.cgi?id=317406&action=review




--- Comment #3 from Brian Burg <bburg at apple.com> ---
Comment on attachment 317406
  --> https://bugs.webkit.org/attachment.cgi?id=317406
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317406&action=review

r=me

> Source/WebDriver/Session.cpp:1525
> +void Session::sendAlertText(const String& text, Function<void
(CommandResult&&)>&& completionHandler)

Nit: 'setAlertText' would match 'getAlertText'