[webkit-reviews] review requested: [Bug 173667] Sort EWS Queues alphabetically on Patch page : [Attachment 316981] Sorted the EWS on the Patch Page

Mon Aug 7 10:02:20 PDT 2017

obinna obike <oobike at apple.com> has asked  for review:
Bug 173667: Sort EWS Queues alphabetically on Patch page
https://bugs.webkit.org/show_bug.cgi?id=173667

Attachment 316981: Sorted the EWS on the Patch Page

https://bugs.webkit.org/attachment.cgi?id=316981&action=review


--- Comment #11 from obinna obike <oobike at apple.com> ---
Comment on attachment 316981
  --> https://bugs.webkit.org/attachment.cgi?id=316981
Sorted the EWS on the Patch Page

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 220109)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2017-08-01  obinna obike  <oobike at apple.com>
>+
>+	  Sorted EWS on patch page
>+	  https://bugs.webkit.org/show_bug.cgi?id=175043
>+
>+	  Reviewed by NOBODY (OOPS!).
>+
>+	  * QueueStatusServer/handlers/patch.py:
>+	  (Patch.get): set queue_status as sorted of queue_status.items()
>+	  * QueueStatusServer/templates/patch.html:
	  changes queue_status.items to queue_status
>+
> 2017-07-26  Jiewen Tan  <jiewen_tan at apple.com>
> 
>	  Add tests to detect mistakes in backward compatibility when the
structured clone algorithm is changed in the future
>Index: Tools/QueueStatusServer/handlers/patch.py
>===================================================================
>--- Tools/QueueStatusServer/handlers/patch.py	(revision 219533)
>+++ Tools/QueueStatusServer/handlers/patch.py	(working copy)
>@@ -44,7 +44,7 @@ class Patch(webapp.RequestHandler):
>	      per_queue_statuses = queue_status.get(status.queue_name, [])
>	      per_queue_statuses.append(status)
>	      queue_status[status.queue_name] = per_queue_statuses
>-
>+	  queue_status = sorted(queue_status.items())
>	  template_values = {
>	      "attachment_id" : attachment_id,
>	      "bug_id" : bug_id,
>Index: Tools/QueueStatusServer/templates/patch.html
>===================================================================
>--- Tools/QueueStatusServer/templates/patch.html	(revision 219533)
>+++ Tools/QueueStatusServer/templates/patch.html	(working copy)
>@@ -7,7 +7,7 @@
> <body>
> <h1>
>   Patch {{ attachment_id|force_escape|webkit_attachment_id|safe }} (Bug {{
bug_id|force_escape|webkit_bug_id|safe }})
>-</h1>{% for queue_name, statuses in queue_status.items %}
>+</h1>{% for queue_name, statuses in queue_status %}
> <div class="status-details">
>   <h2>{{ queue_name }}</h2>
>   <ul>{% for status in statuses %}