[webkit-reviews] review granted: [Bug 167044] Remove ENABLE(WEB_SOCKET) guards : [Attachment 317172] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 167044: Remove ENABLE(WEB_SOCKET) guards
https://bugs.webkit.org/show_bug.cgi?id=167044

Attachment 317172: Patch

https://bugs.webkit.org/attachment.cgi?id=317172&action=review




--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 317172
  --> https://bugs.webkit.org/attachment.cgi?id=317172
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317172&action=review

r=me

> Source/WebCore/page/RuntimeEnabledFeatures.cpp:65
>  bool RuntimeEnabledFeatures::webSocketEnabled() const
>  {
>      return WebSocket::isAvailable();
>  }

WebSocket::setIsAvailable never appears to be called. So this appears to always
be `true` now.

I think we can remove the separate WebSocket::isAvailable /
WebSocket::setIsAvailable path and replace it with normal
RuntimeEnabledFeatures and m_webSocketEnabed bool.

This can be done separately as a follow-up.

> Tools/Scripts/webkitperl/FeatureList.pm:-390
> -	 define => "ENABLE_WEB_SOCKETS", default => 1, value =>
\$webSocketsSupport },

Remove $webSocketsSupport on line 138.