[webkit-reviews] review granted: [Bug 175135] ScrollingTreeOverflowScrollingNodeIOS::updateChildNodesAfterScroll uses the wrong fixedPositionRect : [Attachment 317124] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 175135: ScrollingTreeOverflowScrollingNodeIOS::updateChildNodesAfterScroll
uses the wrong fixedPositionRect
https://bugs.webkit.org/show_bug.cgi?id=175135

Attachment 317124: Patch

https://bugs.webkit.org/attachment.cgi?id=317124&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 317124
  --> https://bugs.webkit.org/attachment.cgi?id=317124
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317124&action=review

> Source/WebCore/ChangeLog:11
> +	   and RenderLayerCompositor. This allows to fix some flickering issues
on iOS.

allows to fix => fixes

> Source/WebKit/ChangeLog:11
> +	   and RenderLayerCompositor. This allows to fix some flickering issues
on iOS.

ditto

>
Source/WebKit/UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
281
> +    if (frameNode && frameNode->parent())
> +	   fixedPositionRect = frameNode->fixedPositionRect();
> +    else
> +	   fixedPositionRect = scrollingTree().fixedPositionRect();

It's not clear why you check frameNode->parent() here. Is
frameNode->fixedPositionRect() on the root frame node not the same as
scrollingTree().fixedPositionRect()?