[webkit-reviews] review granted: [Bug 174140] [WebIDL] Convert MutationCallback to be a normal generate callback : [Attachment 317077] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 174140: [WebIDL] Convert MutationCallback to be a normal generate callback
https://bugs.webkit.org/show_bug.cgi?id=174140

Attachment 317077: Patch

https://bugs.webkit.org/attachment.cgi?id=317077&action=review




--- Comment #40 from Darin Adler <darin at apple.com> ---
Comment on attachment 317077
  --> https://bugs.webkit.org/attachment.cgi?id=317077
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317077&action=review

> Source/WebCore/ChangeLog:3
> +	   [WebIDL] Convert MutationCallback to be a normal generate callback

generated?

> Source/WebCore/Modules/geolocation/PositionCallback.h:38
> +    using ActiveDOMCallback::ActiveDOMCallback;

What does this do? I have never seen this syntax before; it looks like it would
make a base class constructor public, but I not know what that means. And also,
it seems that since we inherit from ActiveDOMCallback publicly that it would
already be public, so what is this for?

> Source/WebCore/Modules/geolocation/PositionCallback.h:40
>      virtual ~PositionCallback() { }

This is no longer needed now that we have a base class that already makes the
detstructor virtual.

> Source/WebCore/Modules/geolocation/PositionCallback.h:41
>      virtual CallbackResult<void> handleEvent(Geoposition*) = 0;

Wish this was a reference instead of a pointer.

> Source/WebCore/Modules/geolocation/PositionErrorCallback.h:40
> +    using ActiveDOMCallback::ActiveDOMCallback;
> +
>      virtual ~PositionErrorCallback() { }

Ditto. Same for all the other classes.