[webkit-reviews] review granted: [Bug 171291] [JSC] Object.keys() must discard property names with no PropertyDescriptor : [Attachment 308178] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted Caitlin Potter (:caitp)
<caitp at igalia.com>'s request for review:
Bug 171291: [JSC] Object.keys() must discard property names with no
PropertyDescriptor
https://bugs.webkit.org/show_bug.cgi?id=171291

Attachment 308178: Patch

https://bugs.webkit.org/attachment.cgi?id=308178&action=review




--- Comment #10 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 308178
  --> https://bugs.webkit.org/attachment.cgi?id=308178
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308178&action=review

Oops, right. r=me :)

> Source/JavaScriptCore/runtime/ObjectConstructor.cpp:733
> +    // Object.keys() cannot skip calling [[GetOwnProperty]] on Proxy
objects, which can observe the call.

Let's add https://tc39.github.io/ecma262/#sec-enumerableownproperties URL here.