[webkit-reviews] review granted: [Bug 170997] Clean up ICU headers : [Attachment 308046] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 24 20:18:59 PDT 2017

JF Bastien <jfbastien at apple.com> has granted Andy VanWagoner
<thetalecrafter at gmail.com>'s request for review:
Bug 170997: Clean up ICU headers

Attachment 308046: Patch


--- Comment #7 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 308046
  --> https://bugs.webkit.org/attachment.cgi?id=308046

View in context: https://bugs.webkit.org/attachment.cgi?id=308046&action=review

Looks good, will wait for bots to be happy too.

> Source/JavaScriptCore/icu/unicode/platform.h:127
> + *  http://www.chromium.org/nativeclient


> Source/JavaScriptCore/icu/unicode/uchar.h:42
> +#define U_UNICODE_VERSION "7.0"

Does this indirectly make us support new things through the system library?
i.e. new things in the .h opt us into thing the library supported but were off
due to some header-declared feature set? I don't know how most of ICU works :)

More information about the webkit-reviews mailing list