[webkit-reviews] review granted: [Bug 168036] [GTK] ImageDiff should be run by jhbuild-wrapper in case of using jhbuild : [Attachment 308050] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Alberto Lopez
Perez <clopez at igalia.com>'s request for review:
Bug 168036: [GTK] ImageDiff should be run by jhbuild-wrapper in case of using
jhbuild
https://bugs.webkit.org/show_bug.cgi?id=168036

Attachment 308050: Patch

https://bugs.webkit.org/attachment.cgi?id=308050&action=review




--- Comment #5 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 308050
  --> https://bugs.webkit.org/attachment.cgi?id=308050
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308050&action=review

Excellent! Nice tests.

> Tools/Scripts/webkitpy/port/base_unittest.py:402
> +	  
port._filesystem.maybe_make_directory(port.path_from_webkit_base('WebKitBuild',
'Dependencies%s' % port.port_name.upper()))

Nit: is there a non-maybe version of this function? If not, you should add one.
It doesn't make sense to say "maybe" here when we want to assert that the path
definitely does not already exist.

> Tools/Scripts/webkitpy/port/port_testcase.py:274
> +	  
port._filesystem.maybe_make_directory(port.path_from_webkit_base('WebKitBuild',
'Dependencies%s' % port.port_name.upper()))

Ditto.