[webkit-reviews] review granted: [Bug 171042] [CG] Provide a type identifier hint to the CGImageSource so getting the type identifier is more accurate : [Attachment 308006] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 171042: [CG] Provide a type identifier hint to the CGImageSource so getting
the type identifier is more accurate
https://bugs.webkit.org/show_bug.cgi?id=171042

Attachment 308006: Patch

https://bugs.webkit.org/attachment.cgi?id=308006&action=review




--- Comment #54 from Tim Horton <thorton at apple.com> ---
Comment on attachment 308006
  --> https://bugs.webkit.org/attachment.cgi?id=308006
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308006&action=review

> Source/WebCore/platform/graphics/Image.cpp:80
> -String Image::sourceURL() const
> +URL Image::sourceURL() const

If it were me, I would do the mechanical change in a separate patch, but this
is fine too.

> Source/WebCore/platform/graphics/Image.h:124
> +    virtual String filenameExtension() const { return emptyString(); } //
null string if unknown

The comment is no longer true. Empty string != null string. That change seems
potentially problematic for callers, too.

> Source/WebCore/platform/image-decoders/ImageDecoder.h:44
> +class URL;

This file is indented wrong, but you should probably stick with it instead of
doing your own thing.