[webkit-reviews] review granted: [Bug 171077] Whitelist supported image MIME types : [Attachment 308013] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 24 15:58:14 PDT 2017


Tim Horton <thorton at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 171077: Whitelist supported image MIME types
https://bugs.webkit.org/show_bug.cgi?id=171077

Attachment 308013: Patch

https://bugs.webkit.org/attachment.cgi?id=308013&action=review




--- Comment #41 from Tim Horton <thorton at apple.com> ---
Comment on attachment 308013
  --> https://bugs.webkit.org/attachment.cgi?id=308013
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308013&action=review

> Source/WebCore/ChangeLog:9
> +	   WebKit should support only a whitelist image formats. WebKit will
not support new
> +	   image formats till they get broader industry adoption.

"should support only whitelisted image formats".

Also, this isn't a generic WebKit policy (obviously), this is about CG ports. I
think you should drop the second sentence, too, since even that isn't a
guarantee of support, of course. Maybe write something helpful about the code
change you made instead?


More information about the webkit-reviews mailing list