[webkit-reviews] review canceled: [Bug 170979] test262: test262/test/language/expressions/generators/yield-as-label.js : [Attachment 307471] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has canceled Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 170979: test262:
test262/test/language/expressions/generators/yield-as-label.js
https://bugs.webkit.org/show_bug.cgi?id=170979

Attachment 307471: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=307471&action=review




--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 307471
  --> https://bugs.webkit.org/attachment.cgi?id=307471
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=307471&action=review

> JSTests/stress/yield-reserved-word.js:80
> +// GeneratorDeclaration inside a generator now has +Yield.
> +checkClassicSyntaxError(`
> +function* foo() { function* yield(){} }
> +`, `SyntaxError: Cannot use the keyword 'yield' as a generator function
name.`);

Clearing review because I want to add more tests like this for nested functions
to ensure that yield inside of a (Function / ArrowFunction / AsyncFunction)
nested inside of a Generator function is allowed.

I'll also use that opportunity to break this up into a couple patches to avoid
the clutter it currently has.