[webkit-reviews] review granted: [Bug 171024] [Win] REGRESSION(r215486): Windows Release build is broken : [Attachment 307536] Patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 19 19:26:42 PDT 2017


Mark Lam <mark.lam at apple.com> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 171024: [Win] REGRESSION(r215486): Windows Release build is broken
https://bugs.webkit.org/show_bug.cgi?id=171024

Attachment 307536: Patch v2

https://bugs.webkit.org/attachment.cgi?id=307536&action=review




--- Comment #7 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 307536
  --> https://bugs.webkit.org/attachment.cgi?id=307536
Patch v2

r=me.  I think this is fine.  Alternatively, you can #include
<JavaScriptCore/JSCInlines.h> which will include many inline goodies. 
#include'ing HeapInlines.h is probably best for now.  JSCInlines.h is
recommended if you need to include multiple *Inlines.h files.


More information about the webkit-reviews mailing list