[webkit-reviews] review requested: [Bug 170875] Cannot compile JavaScriptCore/runtime/VMTraps.cpp on FreeBSD because std::pair has a non-trivial copy constructor : [Attachment 307486] patch

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has asked  for review:
Bug 170875: Cannot compile JavaScriptCore/runtime/VMTraps.cpp on FreeBSD
because std::pair has a non-trivial copy constructor
https://bugs.webkit.org/show_bug.cgi?id=170875

Attachment 307486: patch

https://bugs.webkit.org/attachment.cgi?id=307486&action=review




--- Comment #3 from JF Bastien <jfbastien at apple.com> ---
Created attachment 307486

  --> https://bugs.webkit.org/attachment.cgi?id=307486&action=review

patch

(In reply to Ting-Wei Lan from comment #2)
> (In reply to JF Bastien from comment #1)
> > It is surprising to see the constexpr version being instantiated here.
> 
> JSC::VM*, WTF::StackBounds, JSC::VMTraps::Error are all trivially
> destructible, so WTF::ExpectedDetail::BaseSelect is
> WTF::ExpectedDetail::ConstexprBase here.

Derp, right you are!

Here's a patch that works around the issue.