[webkit-reviews] review granted: [Bug 170825] WebAssembly: limit slow memories : [Attachment 307473] patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted JF Bastien <jfbastien at apple.com>'s
request for review:
Bug 170825: WebAssembly: limit slow memories
https://bugs.webkit.org/show_bug.cgi?id=170825

Attachment 307473: patch

https://bugs.webkit.org/attachment.cgi?id=307473&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 307473
  --> https://bugs.webkit.org/attachment.cgi?id=307473
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=307473&action=review

r=me. I'd like to at least see a test we run on Mac, and if it's flaky, we can
consider what to do next. But let's land it before assuming it'll be flaky.

> Source/JavaScriptCore/ChangeLog:21
> +	   I haven't added a test because the bots will likely be unhappy /

What about at least making it run on Mac?

> Source/JavaScriptCore/wasm/WasmMemory.cpp:203
> +    size_t maximum = fastMemoryAllocationSoftLimit *
Memory::fastMappedBytes();

I would really add a new variable for this, even if initially it's the same
value. That way we can change them independent of one another.