[webkit-reviews] review granted: [Bug 170520] Simple line layout: Hittest always returns the first renderer in the block. : [Attachment 306319] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 170520: Simple line layout: Hittest always returns the first renderer in
the block.
https://bugs.webkit.org/show_bug.cgi?id=170520

Attachment 306319: Patch

https://bugs.webkit.org/attachment.cgi?id=306319&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 306319
  --> https://bugs.webkit.org/attachment.cgi?id=306319
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306319&action=review

> Source/WebCore/rendering/SimpleLineLayoutResolver.h:134
> +	   struct LineOverlap {
> +	       FloatRect rect;
> +	       const RenderObject& renderer;
> +	   };

It would be good idea to add a FIXME here explaining how this is wrong (there
can be multiple renderers per line).

> Source/WebCore/rendering/SimpleLineLayoutResolver.h:142
> -	   const FloatRect operator*() const;
> +	   const LineOverlap operator*() const;

Maybe there could be a separate lineOverlap() function and keep the operator*
as-is? Or do all clients need the renderer too?