[webkit-reviews] review granted: [Bug 170350] [GCrypt] Implement CryptoKeyRSA::generatePair() : [Attachment 305988] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 6 08:18:00 PDT 2017
Michael Catanzaro <mcatanzaro at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 170350: [GCrypt] Implement CryptoKeyRSA::generatePair()
https://bugs.webkit.org/show_bug.cgi?id=170350
Attachment 305988: Patch
https://bugs.webkit.org/attachment.cgi?id=305988&action=review
--- Comment #6 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 305988
--> https://bugs.webkit.org/attachment.cgi?id=305988
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=305988&action=review
OK.
> Source/WebCore/crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:88
> + if (exponent.size() > 4) {
> + if (std::any_of(exponent.begin(), exponent.end() - 4, [](uint8_t
element) { return !!element; }))
> + return std::nullopt;
I'd add a comment here: "ensure exponent is limited to four bytes"
More information about the webkit-reviews
mailing list