[webkit-reviews] review granted: [Bug 169649] Web Inspector: WebSockets: Don't store binary frames in memory since they are never shown : [Attachment 304466] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 169649: Web Inspector: WebSockets: Don't store binary frames in memory
since they are never shown
https://bugs.webkit.org/show_bug.cgi?id=169649

Attachment 304466: Patch

https://bugs.webkit.org/attachment.cgi?id=304466&action=review




--- Comment #8 from Brian Burg <bburg at apple.com> ---
Comment on attachment 304466
  --> https://bugs.webkit.org/attachment.cgi?id=304466
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304466&action=review

r=me

> Source/WebInspectorUI/UserInterface/Models/WebSocketResource.js:74
> +    _dataForWebSocketFrame(data, opcode)

I don't see any reason to make this a private member. Let's just inline this
into addFrame.

> Source/WebInspectorUI/UserInterface/Models/WebSocketResource.js:78
> +	       return "";

This should be null, not an empty string.