[webkit-reviews] review granted: [Bug 170299] We should pause silent WebAudio rendering in background tabs : [Attachment 305933] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 170299: We should pause silent WebAudio rendering in background tabs
https://bugs.webkit.org/show_bug.cgi?id=170299

Attachment 305933: Patch

https://bugs.webkit.org/attachment.cgi?id=305933&action=review




--- Comment #8 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 305933
  --> https://bugs.webkit.org/attachment.cgi?id=305933
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=305933&action=review

> Source/WebCore/dom/VisibilityChangeClient.h:35
> +class VisibilityChangeClient {
> +public:
> +    virtual ~VisibilityChangeClient() { }
> +
> +    virtual void visibilityStateChanged() = 0;
> +};

Anders recently suggested I use a lambda rather than a new "client" class for
an asynch callback. Maybe you should do the same thing here as long as you have
to change all of the call sites?