[webkit-reviews] review granted: [Bug 136805] Web Inspector: FunctionCall timeline records omit profile data if the debugger has paused : [Attachment 238670] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 136805: Web Inspector: FunctionCall timeline records omit profile data if
the debugger has paused
https://bugs.webkit.org/show_bug.cgi?id=136805

Attachment 238670: Patch
https://bugs.webkit.org/attachment.cgi?id=238670&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238670&action=review


> LayoutTests/inspector/timeline/debugger-paused-while-recording.html:56
> +   
WebInspector.debuggerManager.addEventListener(WebInspector.DebuggerManager.Even
t.Paused,
> +	   function(event) {
> +	       InspectorTest.addResult("Debugger paused; resuming...");
> +
> +	       WebInspector.debuggerManager.resume().then(function() {
> +		   InspectorTest.addResult("Debugger resumed; stopping timeline
capture.");
> +		   WebInspector.timelineManager.stopCapturing();
> +	       })
> +
> +    });

function(event) { feels better on the previous line, like the other examples in
this file.

Also extra new line.