[webkit-reviews] review granted: [Bug 131707] Simple ES6 feature: Number constructor extras : [Attachment 238593] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Diego Pino <dpino at igalia.com>'s
request for review:
Bug 131707: Simple ES6 feature: Number constructor extras
https://bugs.webkit.org/show_bug.cgi?id=131707

Attachment 238593: Patch
https://bugs.webkit.org/attachment.cgi?id=238593&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238593&action=review


> LayoutTests/js/script-tests/number-constructor.js:22
> +shouldBeFalse('Number.isFinite(undefined)');

Just for your information, there is no keyword “undefined”. This just works
because undefined is not the name of any variable or property. Could also be
“foo”, which is also undefined.

> LayoutTests/js/script-tests/number-constructor.js:64
> +shouldBeFalse('Number.isNaN(false)');

true?

> LayoutTests/js/script-tests/number-constructor.js:91
> +shouldBeFalse('Number.isSafeInteger(false)');

true?

> LayoutTests/js/script-tests/number-constructor.js:119
> +shouldBe('Number.parseFloat(false)', 'NaN');

true?

> LayoutTests/js/script-tests/number-constructor.js:121
> +shouldBe('Number.parseFloat(null)', 'NaN');

no test of undefined for parseFloat?

> LayoutTests/js/script-tests/number-constructor.js:149
> +shouldBe('Number.parseInt(false)', 'NaN');

true?

> LayoutTests/js/script-tests/number-constructor.js:151
> +shouldBe('Number.parseInt(null)', 'NaN');

no test of undefined for parseInt?