[webkit-reviews] review granted: [Bug 136845] Add parsing for :nth-child(An+B of selector) : [Attachment 238153] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 17 12:38:05 PDT 2014


Antti Koivisto <koivisto at iki.fi> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 136845: Add parsing for :nth-child(An+B of selector)
https://bugs.webkit.org/show_bug.cgi?id=136845

Attachment 238153: Patch
https://bugs.webkit.org/attachment.cgi?id=238153&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=238153&action=review


> Source/WebCore/css/CSSParserValues.cpp:294
> +    for (const CSSSelector* subSelector = selectorList->first();
subSelector; subSelector = CSSSelectorList::next(subSelector)) {

We should come up with iterators for this stuff :|


More information about the webkit-reviews mailing list