[webkit-reviews] review granted: [Bug 136884] Remove unused methods from MediaPlayerClient : [Attachment 238247] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 17 12:19:15 PDT 2014
Eric Carlson <eric.carlson at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 136884: Remove unused methods from MediaPlayerClient
https://bugs.webkit.org/show_bug.cgi?id=136884
Attachment 238247: Patch
https://bugs.webkit.org/attachment.cgi?id=238247&action=review
------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238247&action=review
> Source/WebCore/html/HTMLMediaElement.cpp:5664
> IntRect HTMLMediaElement::mediaPlayerWindowClipRect()
> {
> - return mediaPlayerOwningDocument()->view()->windowClipRect();
> + return document().view()->windowClipRect();
> }
It looks like this can be removed from here and MediaPlayerClient, it isn't
called by MediaPlayer.
More information about the webkit-reviews
mailing list