[webkit-reviews] review denied: [Bug 136818] [AX] Improve AccessibilityTableCell columnHeaders and rowHeaders functions. : [Attachment 238124] proposed patch 2

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has denied Andrzej Badowski
<a.badowski at samsung.com>'s request for review:
Bug 136818: [AX] Improve AccessibilityTableCell columnHeaders and rowHeaders
functions.
https://bugs.webkit.org/show_bug.cgi?id=136818

Attachment 238124: proposed patch 2
https://bugs.webkit.org/attachment.cgi?id=238124&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=238124&action=review


still need to figure out the layout test failures. otherwise the concept seems
ok

> Source/WebCore/accessibility/AccessibilityTableCell.cpp:127
> +    while (parentNode) {

we should add some comments here to explain why we want to do this

> Source/WebCore/accessibility/AccessibilityTableCell.cpp:147
> +	   if (parentNode->hasTagName(tbodyTag) ||
parentNode->hasTagName(tfootTag))

we should add some comments here to explain why we want to do this