[webkit-reviews] review denied: [Bug 132599] [CMake][GTK] CMake Error: Could not create named generator Eclipse CDT4 - Ninja : [Attachment 230886] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Nikos Andronikos
<nikos.andronikos-webkit at cisra.canon.com.au>'s request for review:
Bug 132599: [CMake][GTK] CMake Error: Could not create named generator Eclipse
CDT4 - Ninja
https://bugs.webkit.org/show_bug.cgi?id=132599

Attachment 230886: Patch
https://bugs.webkit.org/attachment.cgi?id=230886&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=230886&action=review


One issue here. It looks like the Windows failure is unrelated.

> Tools/Scripts/webkitdirs.pm:1818
> -    my $willUseNinja = isGtk() && canUseNinja();
> +    my $willUseNinja = isGtk() && canUseNinja() && canUseNinjaGenerator();

It looks like you shouldn't change this line, because if Eclipse support is not
available it should fall back to the typical ninja generator.