[webkit-reviews] review granted: [Bug 136662] Web Inspector: DOM Tree search highlights are not appearing : [Attachment 237837] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 136662: Web Inspector: DOM Tree search highlights are not appearing
https://bugs.webkit.org/show_bug.cgi?id=136662

Attachment 237837: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=237837&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=237837&action=review


> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:472
> +	       if (error)
> +		   return;
> +	       if (this._searchIdentifier !== searchIdentifier)
> +		   return;

Combine? Otherwise I'd throw a newline between these.

> Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:179
> +.dom-tree-outline .highlighted {
> +    color: black;
> +    background-color: rgba(235, 215, 38, 0.2);
> +    border-bottom: 1px solid rgb(237, 202, 71);
> +}
> +
> +.dom-tree-outline li.selected .highlighted,
> +.dom-tree-outline:focus li.selected .highlighted {
> +    background-color: rgba(235, 215, 38, 0.7);
> +    border-bottom: 1px solid rgb(237, 202, 31);
> +}
> +
> +.dom-tree-outline .highlighted .highlight {
> +    background-color: rgb(255, 230, 179);
> +    border-radius: 4px;
> +    padding-bottom: 2px;
> +    margin-bottom: -2px;
> +}

Screenshot?